Filter PRs from forks #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which to generate the changelog
jetersen
approved these changes
May 26, 2020
Comment on lines
+24
to
+38
| { | ||
| "title": "🙅♂️ Forking PR 🙅♂️", | ||
| "number": 1, | ||
| "body": "No thanks to forking PRs", | ||
| "author": { | ||
| "login": "jetersen" | ||
| }, | ||
| "baseRepository": { | ||
| "nameWithOwner": "jetersen/release-drafter-test-repo" | ||
| }, | ||
| "mergedAt": "2020-05-26T20:33:01Z", | ||
| "isCrossRepository": true, | ||
| "labels": { | ||
| "nodes": [] | ||
| } |
There was a problem hiding this comment.
Such PRs are successfully filtered.
Comment on lines
+1241
to
+1242
| * Add documentation (#5) @TimonVS | ||
| * Update dependencies (#4) @TimonVS |
There was a problem hiding this comment.
something went wrong when I created the branch
However the PR with the title 🙅♂️ Forking PR 🙅♂️ is filtered out
Comment on lines
+36
to
+37
| owner: 'jetersen', | ||
| branch: 'forking', |
There was a problem hiding this comment.
Reason for this was because associated PRs does not immediately appear on the main repo or at least that was the behavior I saw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been tested yet. Will add tests asap.
Fixes: #221