New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ValidationError: child "template" fails because ["template" is required]\n' #835
Comments
The config has to be on the default branch. |
@jetersen thank you! makes testing a little tricky but it's not a big deal. I submitted a PR to clarify that in the readme. Thanks. |
Damned ! I wish I had this information 2 hours ago :/ |
@jetersen is there a reason it must be on the default branch? This has bitten me quite a few times, it'd be nice if it was configurable. Happy to contribute a change if it's not a GitHub limitation |
Not a github limit. Could be patched. |
Ran into this again, drives me crazy I can't test my release drafters and have to iterate on main to get it working |
@JustinGrote I'll tackle this when I get some time in the near future 😬 |
Patching it would result in security issues. |
@jetersen why would it be a security issue? PRs won't have a sufficient GITHUB_TOKEN to draft a release, and I can control who creates branches in my repo and what branch those actions enact. Only people who could "abuse" this would be people who can draft their own releases anyways, maybe you can clarify? |
Person with repo write permission can modify the action in a new branch to run draft and create a release and most likely release a binary with nasty bits in it. GITHUB token has permission to both draft and publish releases as the action even offers to publish a release. I prefer that the action requires to be modified on the default branch as that usually provides extra safe guards with branch protection. |
https://github.com/JustinGrote/Press/actions/runs/727435035
I've tried every combination of just the workflow with no config, specifying the config with only template, etc. but I always get this message.
The text was updated successfully, but these errors were encountered: