New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Drafter is *sometimes* including unmerged PRs #917
Comments
We are simply using the GraphQL api. I cannot see where in the code we should be at fault. Maybe there is a bug somewhre here: release-drafter/lib/commits.js Line 63 in 349214e
But 🤷 |
I think @kiview spotted this with one of his PRs in https://github.com/testcontainers/testcontainers-java, although I'm afraid I can't find any current instance of this... I'll keep an eye out and try and provide more info if we see it again. |
I thought this was similar to #766 but it might not be. I see the same thing, and I noticed it happens when the action ran last on the pull-request. For instance, the original repo here has this config: https://github.com/pieforproviders/pieforproviders/blob/025bfe99539df5b8660b4c64e972e2331ee1cb78/.github/workflows/release-drafter.yml I have a similar config on a private repo and noticed that the draft release has an entry for the unmerged PR that last ran. To workaround, I just re-run the last release-drafter workflow on the main branch, and the unmerged PR goes away. I'm using the autolabeler, so I want to keep running on the open PRs. |
I am experiencing the same behavior on a newly configured repository. |
I think this PR may be causing this issue: #632 on:
push:
# branches to consider in the event; optional, defaults to all
branches:
- master
# pull_request event is required only for autolabeler
pull_request:
# Only following types are handled by the action, but one can default to all as well
types: [opened, reopened, synchronize] The PR trigger is nice because it allows the auto-labeler to work, but I think this is causing the release draft to have unmerged PRs added. |
I've been able to work around it using the undocumented input
|
Should be solved by #1015 than that would be odd 🗡️ |
I'm including a screenshot - release drafter has already added a PR that's open and unmerged; my config is as follows:
From what I can tell there's no reason that that PR should be included; I had to remove another one the other day on 0.17 manually, which I will need to add back in manually, I assume, in this release. Is there any way to determine why this is happening?
Link to the repo: https://github.com/pieforproviders/pieforproviders
The text was updated successfully, but these errors were encountered: