Allow more than just a push event to run the action #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I know this is an simply change. But this would affect the github app application as well. It would be much preferred to wait for #549 |
|
No problem! Take your time! 😄 |
|
I have an extended weekend coming up, so hopefully soon(tm) |
rouge8
added a commit
to GoodRx/release-drafter
that referenced
this pull request
Aug 28, 2020
Previously release-drafter would only run on push events which is why our attempt to use it in a cron job for Gold were not doing anything. ref: release-drafter#612 ref: release-drafter#632 ref: release-drafter#549
|
don't mind me, just testing something. /rebase fair enough, however the trigger works! https://github.com/release-drafter/release-drafter/runs/1611840422?check_suite_focus=true |
|
👋 @MindaugasLaganeckas I chose to make this conditional to support both use cases. |
jetersen
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to propose a change, where it is the github action determines, when a release-drafter should be run.
We have a usecase, where it is a workflow dispatch event, that triggers the action and this line:
app.on('push', async (context) => {prevents the action to run.Maybe there is a better way to solve this problem rather than replacing
pushwith*. Your input is welcome.