Add sort-direction option
#192
Conversation
|
I can't select people who aren't a member of the repo as a reviewer 🤔. But I'd appreciate @Casz review as well 🙇♂️. |
|
I'd be happy to be considered a member of the repo 👍 💪 |
| @@ -27,6 +33,7 @@ module.exports = app => { | |||
| context, | |||
| replacers: config.replacers | |||
| }) | |||
| config['sort-direction'] = validateSortDirection(config['sort-direction']) | |||
There was a problem hiding this comment.
It's probably better to solve this with a Joi schema?
There was a problem hiding this comment.
I'll see if I can get around to it today 👍
There was a problem hiding this comment.
No need to hurry! If you don't get around to it we can simply create an issue to improve this later :)
|
Should be easy for me to add into schema so perhaps my PR supersedes his? 😆 |
|
So, after doing a quick test, I'm thinking we should reverse the default sort order @TimonVS, and make it |
|
Your call, |
|
Cool. I remember why I thought that maybe But TBH, I'm not really fussed enough to change it either. Let's wait for feedback and see. |
|
My 2 cents is I found ascending confusing, took me a while to get over 😆 however I much prefer descending. |
This PR adds the
sort-directionoption. Valid values areascendingordescending. I do notice that the list of configuration options is getting quite long, we may want to split up more advanced configuration options like this one into another document in the near future.Fixes: #188