Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sort-by option #324

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add sort-by option #324

merged 1 commit into from
Dec 3, 2019

Conversation

ryamaguchi0220
Copy link
Contributor

@ryamaguchi0220 ryamaguchi0220 commented Nov 12, 2019 •
edited
Loading

Closes #323

This PR adds the sort-by option for users to be able to sort changelogs by merged_at or title.

@ryamaguchi0220
Copy link
Contributor Author

ryamaguchi0220 commented Nov 29, 2019 •
edited
Loading

@TimonVS Can I have your moment to get review?

@ryamaguchi0220
Copy link
Contributor Author

@Casz If you have time I'd appreciate your review as well.

@TimonVS
Copy link
Member

TimonVS commented Dec 2, 2019

The PR looks good! I left a comment on the issue to discuss the merit of the feature: #323 (comment)

@ryamaguchi0220
Copy link
Contributor Author

I replied to the comment: #323 (comment)

@TimonVS TimonVS merged commit 63fc460 into release-drafter:master Dec 3, 2019
@ryamaguchi0220 ryamaguchi0220 deleted the feature/sort-by branch December 4, 2019 01:37
@ryamaguchi0220 ryamaguchi0220 changed the title Add a sort-by option Add sort-by option Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonVS TimonVS TimonVS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for sorting PRs by the title
2 participants
@ryamaguchi0220 @TimonVS