Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extracting commit numbers #38

Merged
merged 3 commits into from
Aug 7, 2018
Merged

Fix extracting commit numbers #38

merged 3 commits into from
Aug 7, 2018

Conversation

balloob
Copy link
Contributor

@balloob balloob commented Aug 7, 2018 •
edited by toolmantim

When a PR is squashed and merged, the commit message will contain multiple lines:

<PR TITLE> (#<PR NUMBER>)

<FIRST COMMIT MESSAGE>

<SECOND COMMIT MESSAGE>

etc

When we were extracting PR numbers, we were matching against a commit message ending in (#1234). However, we should have looked at the first line of a commit message ending in that.

Fixes #29

@balloob balloob mentioned this pull request Aug 7, 2018
Closed
@balloob balloob changed the title Add tests for extracting commit numbers Fix extracting commit numbers Aug 7, 2018
toolmantim
toolmantim approved these changes Aug 7, 2018
View reviewed changes
Copy link
Collaborator

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing! 🙌🏼 Thanks so much for taking the time to put together the PR. I made some standardjs style fixes—but otherwise, looks great 👌🏼

@toolmantim toolmantim merged commit 068d79a into release-drafter:master Aug 7, 2018
@toolmantim
Copy link
Collaborator

Alright, this is included in v2.0.4 (🥁 Marching Orders) and is live. Thanks again for the contribution!

@balloob balloob deleted the tests-commit-extract branch August 7, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toolmantim toolmantim toolmantim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balloob @toolmantim