Add include-labels option #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris-reynolds
changed the title
kris-reynolds
changed the title
kris-reynolds
changed the title
jetersen
reviewed
Apr 22, 2020
Co-Authored-By: Joseph Petersen <josephp90@gmail.com>
kris-reynolds
changed the title
|
Is this still to be considered WIP @kreyusb ? |
|
@jetersen We have been using it like this on our Company configuration for the last couple of weeks with no changes. I would say it is good to go. |
|
Can we go ahead and merge this? Seems like everyone is happy. I see nothing blocking and concerned good code is just getting stuck and we're getting merge conflicts. |
|
There is currently a conflict, do you mind solving it kreyusb? |
|
Many thanks for your contribution! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding feature discussed in: #499
Note, feature has not been agreed upon yet. Consider this WIP until feature has consensus.
fixes #499