New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $NEXT_{PATCH,MINOR,MAJOR}_VERSION_{PATCH,MINOR,MAJOR} variables #823
Add $NEXT_{PATCH,MINOR,MAJOR}_VERSION_{PATCH,MINOR,MAJOR} variables #823
Conversation
debf11e
to
572661b
Compare
This pull request is ready, the tests pass. Feedback welcome. |
From the tests, I cannot see that this has added the desired variables 🤔 and how you want to use it. |
Use docker with a node js container with an interactive shell
|
572661b
to
054b5af
Compare
@jetersen Thanks for the feedback. I updated the pull request - better testing is in place now. Please have a look again, thanks! |
@jetersen Can you review (if you have time of course) thanks! |
@jetersen What do you think about this pull request? |
@jetersen I would love to hear your opinion on this pull request, thanks! |
@jetersen I would highly appreciate your feedback, thank you very much! |
@jetersen Thanks! |
@mkurz Your welcome! Thanks for contributing. Sorry for my non responsiveness sometimes it gets busy. 😅 |
@jetersen Any chance to cut a new release of release-drafter soon? |
In our use case just having the full version string available in the template isn't enough.
E.g.
$NEXT_MINOR_VERSION
will render the full e.g.2.8.0
, but want to render headings that just contain "2.8" (Like "What's new in Play 2.8?", but more importantly we have links to our docs that look likeSo we need to be able to render versions like "2.8.x" or just "28".
With this PR we can do this via: "
$NEXT_MINOR_VERSION_MAJOR.$NEXT_MINOR_VERSION_MINOR.x
" and "$NEXT_MINOR_VERSION_MAJOR$NEXT_MINOR_VERSION_MINOR
"