Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $NEXT_{PATCH,MINOR,MAJOR}_VERSION_{PATCH,MINOR,MAJOR} variables #823

Merged

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Mar 25, 2021

In our use case just having the full version string available in the template isn't enough.
E.g. $NEXT_MINOR_VERSION will render the full e.g. 2.8.0, but want to render headings that just contain "2.8" (Like "What's new in Play 2.8?", but more importantly we have links to our docs that look like

So we need to be able to render versions like "2.8.x" or just "28".
With this PR we can do this via: "$NEXT_MINOR_VERSION_MAJOR.$NEXT_MINOR_VERSION_MINOR.x" and "$NEXT_MINOR_VERSION_MAJOR$NEXT_MINOR_VERSION_MINOR"

@mkurz mkurz force-pushed the NEXT_X_VERSION_MAJOR_MINOR_PATCH branch from debf11e to 572661b Compare March 25, 2021 10:54
@mkurz
Copy link
Contributor Author

mkurz commented Mar 25, 2021

This pull request is ready, the tests pass. Feedback welcome.
However, formatting fails, can someone please run yarn prettier && yarn lint --fix && yarn build for me on this pull request? I don't use this tools and want to avoid to download and install it just for this PR (I never develop js/node.js)

@jetersen
Copy link
Member

jetersen commented Mar 25, 2021

From the tests, I cannot see that this has added the desired variables 🤔 and how you want to use it.

@jetersen
Copy link
Member

However, formatting fails, can someone please run yarn prettier && yarn lint --fix && yarn build for me on this pull request? I don't use this tools and want to avoid to download and install it just for this PR (I never develop js/node.js)

Use docker with a node js container with an interactive shell

docker run -it --rm -v ${PWD}:/src -w /src node /bin/bash
yarn
yarn prettier && yarn lint --fix && yarn build 

@mkurz mkurz force-pushed the NEXT_X_VERSION_MAJOR_MINOR_PATCH branch from 572661b to 054b5af Compare March 25, 2021 15:31
@mkurz
Copy link
Contributor Author

mkurz commented Mar 25, 2021

@jetersen Thanks for the feedback. I updated the pull request - better testing is in place now. Please have a look again, thanks!

@mkurz
Copy link
Contributor Author

mkurz commented Mar 30, 2021

@jetersen Can you review (if you have time of course) thanks!

@mkurz
Copy link
Contributor Author

mkurz commented May 3, 2021

@jetersen What do you think about this pull request?

@mkurz
Copy link
Contributor Author

mkurz commented May 31, 2021

@jetersen I would love to hear your opinion on this pull request, thanks!

@mkurz
Copy link
Contributor Author

mkurz commented Jul 12, 2021

@jetersen I would highly appreciate your feedback, thank you very much!

@jetersen jetersen merged commit f92c808 into release-drafter:master Sep 6, 2021
@mkurz mkurz deleted the NEXT_X_VERSION_MAJOR_MINOR_PATCH branch September 6, 2021 15:47
@mkurz
Copy link
Contributor Author

mkurz commented Sep 6, 2021

@jetersen Thanks!

@jetersen
Copy link
Member

jetersen commented Sep 6, 2021

@mkurz Your welcome! Thanks for contributing.

Sorry for my non responsiveness sometimes it gets busy. 😅

@mkurz
Copy link
Contributor Author

mkurz commented Dec 27, 2021

@jetersen Any chance to cut a new release of release-drafter soon?

@jetersen jetersen added the type: feature New feature or request label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants