-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to apply labels when upstream issue is closed #105
Merged
sidpremkumar
merged 5 commits into
release-engineering:master
from
csomh:apply-labels-on-close
May 18, 2020
Merged
Add support to apply labels when upstream issue is closed #105
sidpremkumar
merged 5 commits into
release-engineering:master
from
csomh:apply-labels-on-close
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly a cosmetic change. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
So that the function can be used in other places, too. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
Has this been tested locally? |
I don't have the environment to do so, so it wasn't. |
Okay, when we are ready to merge. I will test locally prior. |
Make it possible to configure a list of labels to be applied on Jira cards, when the corresponding upstream issue is closed. This can come handy, when one doesn't want to automatically close downstream issues when upstream issues are closed, but still want's to have an easy way to filter for such issues in Jira. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
This way local testruns will do the same checks as Travis. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
sidpremkumar
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to configure a list of labels to be applied on Jira
cards, when the corresponding upstream issue is closed.
Example:
This can come handy, when one doesn't want to automatically close
downstream issues when upstream issues are closed, but still want's to
have an easy way to filter for such issues in Jira.