Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to apply labels when upstream issue is closed #105

Merged
merged 5 commits into from
May 18, 2020
Merged

Add support to apply labels when upstream issue is closed #105

merged 5 commits into from
May 18, 2020

Conversation

csomh
Copy link

@csomh csomh commented May 15, 2020

Make it possible to configure a list of labels to be applied on Jira
cards, when the corresponding upstream issue is closed.

Example:

{
    'issue_updates': [
        {'on_close': {'apply_labels': ['closed-upstream']}
    ]
}

This can come handy, when one doesn't want to automatically close
downstream issues when upstream issues are closed, but still want's to
have an easy way to filter for such issues in Jira.

Hunor Csomortáni added 2 commits May 15, 2020 17:13
Mostly a cosmetic change.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
So that the function can be used in other places, too.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
@sidpremkumar
Copy link
Collaborator

Has this been tested locally?

@csomh
Copy link
Author

csomh commented May 18, 2020

Has this been tested locally?

I don't have the environment to do so, so it wasn't.

@sidpremkumar
Copy link
Collaborator

Has this been tested locally?

I don't have the environment to do so, so it wasn't.

Okay, when we are ready to merge. I will test locally prior.

Hunor Csomortáni added 3 commits May 18, 2020 18:29
Make it possible to configure a list of labels to be applied on Jira
cards, when the corresponding upstream issue is closed.

This can come handy, when one doesn't want to automatically close
downstream issues when upstream issues are closed, but still want's to
have an easy way to filter for such issues in Jira.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
This way local testruns will do the same checks as Travis.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
@sidpremkumar
Copy link
Collaborator

It looks like its working. Merging:
image

Copy link
Collaborator

@sidpremkumar sidpremkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sidpremkumar sidpremkumar merged commit 29b9e7e into release-engineering:master May 18, 2020
@csomh csomh deleted the apply-labels-on-close branch May 19, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants