pagure auth fails if token file contains trailing newline [RHELDST-2567] #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinglingXiang
requested review from
rohanpm,
rajulkumar and
rbikar
as code owners
|
@LinglingXiang Please rebase it on top of #59 for the tests to succeed. |
1.Remove the trailing newline
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 2 2
Lines 1517 1517
=======================================
Hits 1326 1326
Misses 191 191
☔ View full report in Codecov by Sentry. |
rajulkumar
approved these changes
Jun 29, 2023
rohanpm
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Remove the trailing newline