Integration tests: move cached deps test data to file #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhmanova
force-pushed
the
move-cached-tests-to-file
branch
from
3999aa9
to
39df672
Compare
ejegrova
reviewed
Nov 10, 2020
akhmanova
force-pushed
the
move-cached-tests-to-file
branch
from
39df672
to
c2e36df
Compare
ejegrova
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We planned to move all integration test data from
test_env_vars.yamlintotest_datadirectory. But looks like we can not wait for the cached dependencies test.Changes:
test_data/cached_dependencies.yamlutils.load_test_data()to get test data from fileself.test_env-->self.env_data