cdn-definitions should only contain reference data [RHELDST-4701] #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Production ("live") data definitions should be reserved for
cdn-definitions-private.
rohanpm
requested changes
Mar 4, 2021
There was a problem hiding this comment.
I think it's too early to do this. We just released the new version of the project with rhui_aliases and origin_aliases still working but deprecated. This commit effectively changes them to return dummy data, "breaking" them from the point of view of any existing users, so if we were to release this immediately we're giving only 1 day deprecation period.
Can we wait at least a month or so?
|
Yes, that's fine. I wanted to submit the PR now as opposed to a month(s) from now so the removal of the live data isn't forgotten. If it's okay with you, I'll leave this PR open and it can be merged or reveiwed whenever is appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production ("live") data definitions should be reserved for
cdn-definitions-private.