Don't depend on dist-git-selinux inside containers #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container environments usually don't have the selinux-policy-targeted package installed, and SELinux isn't enabled from the "inside" perspective. Therefore, let's don't depend on the selinux sub-package as long as the selinux-policy-targeted package isn't installed. This dependency conditional idiom is for quite some time used in copr-backend.spec (and friends) with the corresponding copr-selinux package.
|
Thank you. Good idea. |
fedora-copr-github-bot
pushed a commit
to fedora-copr/copr
that referenced
this pull request
Aug 3, 2020
SELinux is _not_ running inside a consider, but on host (outside). Not only the installation of copr-selinux is useless inside -- there also are some weird problems with the installation of selinux-policy package (transitive dep) inside a buildah container. We already use conditional Requires: in Copr packages, but there's still a problem in dist-git.spec: dist-git brings -> dist-git-selinux -> selinux-policy. This causes container image build problems. Will be fixed here: release-engineering/dist-git#40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container environments usually don't have the selinux-policy-targeted
package installed, and SELinux isn't enabled from the "inside"
perspective.
Therefore, let's don't depend on the selinux sub-package as long as
the selinux-policy-targeted package isn't installed. This
dependency conditional idiom is for quite some time used in
copr-backend.spec (and friends) with the corresponding copr-selinux
package.