Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers: use uvicorn via gunicorn rather than directly #10

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

rohanpm
Copy link
Member

@rohanpm rohanpm commented Aug 7, 2020

This container is ultimately intended for use in production, so
let's follow the advice from uvicorn docs[1] which is to use
the gunicorn server.

(I'm not aware of any specific problem with running uvicorn
directly; this is mainly a matter of following the suggested
configuration.)

[1] https://www.uvicorn.org/deployment/

This container is ultimately intended for use in production, so
let's follow the advice from uvicorn docs[1] which is to use
the gunicorn server.

(I'm not aware of any specific problem with running uvicorn
directly; this is mainly a matter of following the suggested
configuration.)

[1] https://www.uvicorn.org/deployment/
@rohanpm rohanpm marked this pull request as ready for review August 7, 2020 05:12
@rohanpm rohanpm requested a review from lmilbaum August 7, 2020 05:12
@rohanpm rohanpm merged commit c98b549 into release-engineering:master Aug 10, 2020
@rohanpm rohanpm deleted the gunicorn branch August 10, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants