Adjusting tox to run on RHEL7 CSB #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crungehottman
approved these changes
Aug 25, 2020
rohanpm
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
If this works for you and for CI, good, but I think in general having one test-requirements.txt with locked versions and hashes crossing multiple python versions is prone to issues. If it works now, it might break later if the set of indirect dependencies changes based on the python version (requiring e.g. a test-requirements-py36.txt, test-requirements-py37.txt). Of course, we can cross that bridge when we come to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.