Fix pylint failure "raise-missing-from" #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint 2.6.0 released on 2020-08-20 added a new raise-missing-from check, which fails on this code. It appears to suggest using an explicit "from" whenever a chained exception is raised. In this case, raising "from None" seems most appropriate, as we are aiming to give the user a terse HTTP error without details of any internal exceptions (which have already been logged).
lmilbaum
approved these changes
Sep 7, 2020
|
pylint version should be pinned to avoid such cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint 2.6.0 released on 2020-08-20 added a new raise-missing-from
check, which fails on this code. It appears to suggest using an
explicit "from" whenever a chained exception is raised.
In this case, raising "from None" seems most appropriate, as we
are aiming to give the user a terse HTTP error without details of
any internal exceptions (which have already been logged).