Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require authorization for upload and publish APIs [RHELDST-4729] #217

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

negillett
Copy link
Member

Users must now possess the appropriate role to request uploads or
publishes to a particular environment, e.g., "stage-blob-uploader" to
upload to the "stage" environment.

The development environment was updated to automatically authorizate
users for the "test" environment.

@negillett negillett self-assigned this Feb 25, 2021
@rohanpm
Copy link
Member

rohanpm commented Mar 1, 2021

Looks good to me, the only missing thing is docs:

Could we please have doc strings updated so that the endpoints which require authorization have the needed roles showing at https://release-engineering.github.io/exodus-gw/api.html ?

My suggestion for how to do this is to have it as the second paragraph of the doc string on the relevant endpoints, in a consistent style. So, for example, update_publish_items doc string might look like:

Add publish items to an existing publish object.

**Required roles**: `{env}-publisher`

Publish items primarily are a mapping between a URI relative to the root of the CDN,
and the key of a binary object which should be exposed from that URI.
(...)

Users must now possess the appropriate role to request uploads or
publishes to a particular environment, e.g., "stage-blob-uploader" to
upload to the "stage" environment.

The development environment was updated to automatically authorizate
users for the "test" environment.
@negillett negillett marked this pull request as ready for review March 3, 2021 15:17
@negillett negillett requested review from dichn and lipoja March 3, 2021 15:17
@negillett negillett merged commit f7e699a into release-engineering:master Mar 3, 2021
@negillett negillett deleted the api-auth branch March 3, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants