Skip to content

Commit

Permalink
Fix condition in lambda deploy template
Browse files Browse the repository at this point in the history
Previously, the EnableKeyGroup condition in exodus-lambda-deploy.yaml
checked that a joined list of keyids was an empty string. However, the
default value of keyids is the string "None", so the joined keyids
string will never be "".

The failure of this condition meant that an attempt was made to create
a KeyGroup resource even when no valid IDs existed.

This commit corrects the condition to look for the string "None".
  • Loading branch information
negillett committed Mar 10, 2022
1 parent 8170ddb commit 8ce8142
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions configuration/exodus-lambda-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ Parameters:
Description: A list of secret key IDs for Distribution key groups

Conditions:
EnableKeyGroup: !Not
- !Equals
- !Join ["", !Ref keyids]
- ""
EnableKeyGroup:
!Not [!Equals [!Join ["", !Ref keyids], None]]

Resources:
KeyGroup:
Expand Down

0 comments on commit 8ce8142

Please sign in to comment.