Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a template error #325

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Fix a template error #325

merged 1 commit into from
Mar 10, 2022

Conversation

dichn
Copy link
Collaborator

@dichn dichn commented Mar 9, 2022

CF stack "exodus-lambda-dev" throw a template error: every Fn::Equals
object requires a list of 2 string parameters.

(1) Cast keyids(CommaDelimitedList) to String
(2) None -> ""

CF stack "exodus-lambda-dev" throw a template error: every Fn::Equals
object requires a list of 2 string parameters.

(1) Cast keyids(CommaDelimitedList) to String
(2) None -> ""
@@ -32,8 +32,8 @@ Parameters:
Conditions:
EnableKeyGroup: !Not
- !Equals
- !Ref keyids
- None
- !Join ["", !Ref keyids]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object to the fix if it works, but I find this a little suspicious because here's the doc for Equals: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-conditions.html#intrinsic-function-reference-conditions-equals

And it says there about the parameters:

A value of any type that you want to compare.

It's explicitly calling out that it should work on "any type". So something seems to be wrong here, either in the docs or in our understanding of the problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohanpm I think the error message Template error: every Fn::Equals object requires a list of 2 string parameters. is conflicted with this statement A value of any type that you want to compare.
So I think the doc may be wrong.

@dichn dichn merged commit 8170ddb into release-engineering:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants