Add "X-Exodus-Query" header #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-push for fixing a typo in commit message (no code change) |
rohanpm
requested changes
Apr 8, 2022
There was a problem hiding this comment.
I think the commit message is misleading:
- this has nothing to do with
https://aws.amazon.com/blogs/compute/implementing-safe-aws-lambda-deployments-with-aws-codedeploy/ , which is not something we're using or will be able to use - I don't think "Because of the traffic shift and traffic will be routed to different
lambda versions (in different regions)" is correct. At best it's misleading to say this is because of "traffic shift" and then link to an article about a kind of traffic shifting we're not doing.
Could the commit message please stick with the known facts? You don't have to put forward a theory as to why we might be hitting an old version of the lambda sometimes.
I would have written something like "Our tests sometimes seem to hit an old version of our lambda, for unclear reasons. Let's make it possible to query the currently deployed lambda version so we can at least reliably detect when this happens."
| @@ -33,6 +33,12 @@ def handler(self, event, context): | |||
| {"key": "Digest", "value": f"id-sha-256={sum_b64}"} | |||
| ] | |||
|
|
|||
| if "headers" in request and "x-exodus-query" in request["headers"]: | |||
| self.logger.error("x-exodus-query exist") | |||
There was a problem hiding this comment.
Please drop this as it's not an error. You could keep a debug() if you really need it.
|
rohanpm
previously approved these changes
Apr 8, 2022
Our tests sometimes seem to hit an old version of our lambda, for unclear reasons. Let's make it possible to query the currently deployed lambda version so we can at least reliably detect when this happens. The "X-Exodus-Query" header is primarily used in a request, to provide the version of exodus-lambda, "X-Exodus-Version" in response.
|
re-push after the rebase of #337 |
crungehottman
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the traffic shift and traffic will be routed to different
lambda versions (in different regions), integration tests may run again
an old version lambda.
The "X-Exodus-Query" header is primarily used in a request, to provide
the version of exodus-lambda, "X-Exodus-Version" in response.
For traffic shift:
https://aws.amazon.com/blogs/compute/implementing-safe-aws-lambda-deployments-with-aws-codedeploy/