Make version 1.0.0 to indicate stable release #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project has already been used in production for some time, so backwards-compatibility is already important. The project also claims to follow semver, but semver doesn't have any impact until version 1.0.0. Per [1], "If your software is being used in production, it should probably already be 1.0.0." "Used by production service" and "this project is alpha, version 0.x and we can change anything at any time" are not compatible; it is time to take stability seriously. Mark the version as 1.0.0 accordingly. [1] https://semver.org/spec/v2.0.0.html
querti
reviewed
Oct 19, 2020
I think it probably should, though it's less important and I guess harder to enforce as well, since that project isn't quite a plain library. |
querti
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has already been used in production for some time,
so backwards-compatibility is already important. The project
also claims to follow semver, but semver doesn't have any impact
until version 1.0.0. Per [1], "If your software is being used in
production, it should probably already be 1.0.0."
"Used by production service" and "this project is alpha,
version 0.x and we can change anything at any time" are not
compatible; it is time to take stability seriously. Mark the
version as 1.0.0 accordingly.
[1] https://semver.org/spec/v2.0.0.html