Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & re-nominate CODEOWNERS #29

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

rohanpm
Copy link
Member

@rohanpm rohanpm commented Oct 19, 2020

This repo had a CODEOWNERS file, but it never worked since it didn't
use the correct syntax. Let's make it work and also revise the list
of owners according to actual contributors (new nominated owners are
the top 3 committers).

This repo had a CODEOWNERS file, but it never worked since it didn't
use the correct syntax. Let's make it work and also revise the list
of owners according to actual contributors (new nominated owners are
the top 3 committers).
@rohanpm rohanpm marked this pull request as ready for review October 19, 2020 01:20
@rohanpm
Copy link
Member Author

rohanpm commented Oct 19, 2020

@midnightercz @lipoja @querti

I happened to notice that CODEOWNERS was never set correctly on this repo. Please check if this list of owners feels right to you.

Copy link
Contributor

@querti querti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLOUDDST is splitting into two scrum teams very soon, so it's possible that some of the proposed owners won't maintain this project going forward.

I think we should put a pin in this until it sorts itself out.

@lipoja
Copy link
Contributor

lipoja commented Oct 19, 2020

CLOUDDST is splitting into two scrum teams very soon, so it's possible that some of the proposed owners won't maintain this project going forward.

I think we should put a pin in this until it sorts itself out.

I think this is based on contribution and how well you know this lib and not how we are split in scrum teams.

@rohanpm
Copy link
Member Author

rohanpm commented Oct 20, 2020

I think you should accept a nomination as CODEOWNER if and only if you're willing to be active on review for the project, will help to make releases, will help to make design decisions etc.

This isn't directly connected to whether you expect your team to produce work for this project. After all, you already don't have items appearing in your team's backlog asking you to review changes to this project, and same will be true after any team refactorings. There also isn't any rule that you should only review changes relevant to your team (in fact it's explicitly not supposed to be that way).

I see it as each dev's personal choice, do you want to share responsibility for the direction of this project or not. What your team asks you to work on is one of the factors for consideration, but not a dominant one.

@rohanpm rohanpm merged commit 383bb2a into release-engineering:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants