Fix linting errors

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>

omps/api/v1/__init__.py

@@ -7,4 +7,4 @@
 
 API = Blueprint('v1', __name__)
 
-from . import packages, push  # register routes
+from . import packages, push  # noqa, register routes

omps/api/v1/packages.py

@@ -8,13 +8,13 @@
 import requests
 
 from . import API
-from omps.quay import QUAY_ORG_MANAGER, ReleaseVersion
+from omps.quay import QUAY_ORG_MANAGER
 
 logger = logging.getLogger(__name__)
 
 
 @API.route("/<organization>/<repo>", defaults={'version': None},
-                 methods=('DELETE',))
+           methods=('DELETE',))
 @API.route("/<organization>/<repo>/<version>", methods=('DELETE',))
 def delete_package_release(organization, repo, version=None):
     """

omps/api/v1/push.py

@@ -110,7 +110,7 @@ def _get_package_version(quay_org, repo, version=None):
 
 
 @API.route("/<organization>/<repo>/zipfile", defaults={"version": None},
-                 methods=('POST',))
+           methods=('POST',))
 @API.route("/<organization>/<repo>/zipfile/<version>", methods=('POST',))
 def push_zipfile(organization, repo, version=None):
     """

omps/app.py

@@ -44,4 +44,5 @@ def _register_blueprints(app):
     logger.debug('Registering blueprints')
     app.register_blueprint(API_V1, url_prefix='/v1')
 
+
 app = create_app()

omps/quay.py

@@ -307,10 +307,10 @@ def get_latest_release_version(self, repo):
             # no valid versions found, assume that this will be first package
             # uploaded by service
             raise QuayPackageNotFound(
-                    "Package {}/{} has not valid versions uploaded".format(
-                        self._organization, repo
-                    )
+                "Package {}/{} has not valid versions uploaded".format(
+                    self._organization, repo
                 )
+            )
 
         return max(self.get_releases(repo))
 

omps/settings.py

@@ -116,8 +116,6 @@ class Config(object):
         }
     }
 
-
-
     def __init__(self, conf_section_obj):
         """
         Initialize the Config object with defaults and then override them
@@ -190,10 +188,12 @@ def set_item(self, key, value):
                     if value is not None:
                         value = convert(value)
                 except (TypeError, ValueError):
-                    raise TypeError("Configuration value conversion failed for name: %s" % key)
+                    error = "Configuration value conversion failed for name: %s"
+                    raise TypeError(error % key)
             # unknown type/unsupported conversion
             elif convert is not None:
-                raise TypeError("Unsupported type %s for configuration item name: %s" % (convert, key))
+                error = "Unsupported type %s for configuration item name: %s"
+                raise TypeError(error % (convert, key))
 
         # Set the attribute to the correct value
         setattr(self, key, value)

tests/api/__init__.py

@@ -80,6 +80,8 @@ def test_push_koji_nvr(client):
 
 
 ZIP_ENDPOINT_NOVER = '/organization-X/repo-Y/zipfile'
+
+
 @pytest.mark.parametrize('endpoint', [
     ZIP_ENDPOINT_NOVER,
     '/organization-X/repo-Y/zipfile/1.0.1',
@@ -114,4 +116,3 @@ def test_404_for_mistyped_entrypoints(client, endpoint):
     rv_json = rv.get_json()
     assert rv_json['error'] == 'NotFound'
     assert rv_json['status'] == 404
-

tests/api/v1/test_api_push.py

@@ -80,6 +80,8 @@ def test_push_koji_nvr(client):
 
 
 ZIP_ENDPOINT_NOVER = '/v1/organization-X/repo-Y/zipfile'
+
+
 @pytest.mark.parametrize('endpoint', [
     ZIP_ENDPOINT_NOVER,
     '/v1/organization-X/repo-Y/zipfile/1.0.1',

tests/conftest.py

@@ -37,7 +37,7 @@ def datadir(tmpdir):
 
     :return: tmpdir data path
     """
-    path =  os.path.join(tmpdir, "data")
+    path = os.path.join(tmpdir, "data")
     data_dir = os.path.join(os.path.dirname(__file__), "data")
     shutil.copytree(data_dir, path)
     return path

tox.ini

@@ -31,3 +31,6 @@ commands = flake8
 
 [flake8]
 max-line-length: 90
+ignore =
+    # E731 do not assign a lambda expression, use a def
+    E731