This repository has been archived by the owner on May 24, 2023. It is now read-only.
Test fetching from Koji by NVR #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
csomh
changed the title
MartinBasti
reviewed
Mar 11, 2019
tests/integration/README.md
Outdated
| @@ -25,6 +25,12 @@ For example: `https://quay.io/api/v1`. | |||
|
|
|||
| `OMPS_INT_TEST_QUAY_PASSWD`: Password to authenticate with Quay. | |||
|
|
|||
| `OMPS_INT_TEST_KOJI_NVRS`: A comma-separated list of Koji build NVRs, in the | |||
There was a problem hiding this comment.
Could we have 3 env vars instead?
There was a problem hiding this comment.
Moved all integration test configs to test.env.yaml. Updated docs accordingly.
cc @chmeliik
added 2 commits
March 12, 2019 14:02
Update on of the integration tets for the NVR endpoint, to also check that the bundle uploaded by OMPS to Quay, matches the data stored in Koji. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
The number of environment variables grew too big, so moving integration test configuration to a YAML file, easier to read by humans. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
csomh
changed the title
MartinBasti
approved these changes
Mar 13, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hunor Csomortáni csomh@redhat.com