This repository has been archived by the owner on May 24, 2023. It is now read-only.
Allow configuring a timeout for requests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make the timout explicit for gunicorn workers in the Dockerfile. 2. Extend configuration with a 'REQUEST_TIMEOUT' option, which should be considered both for Koji and Quay requests. For the later, the only exception is the push operation, as Operator Courier API does not have a timeout option yet. All the above is done, so that the OMPS can be configured in a way, where requests time out sooner than the workers. This way we hope to catch some issues currently hidden by the worker timeouts. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
|
I forgot about documentation. It should be updated accordingly |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the timout explicit for gunicorn workers in the Dockerfile.
Extend configuration with a 'REQUEST_TIMEOUT' option, which should be
considered both for Koji and Quay requests. For the later, the only
exception is the push operation, as Operator Courier API does not
have a timeout option yet.
All the above is done, so that the OMPS can be configured in a way,
where requests time out sooner than the workers. This way we hope to
catch some issues currently hidden by the worker timeouts.
Signed-off-by: Hunor Csomortáni csomh@redhat.com