This repository has been archived by the owner on May 24, 2023. It is now read-only.
Log OMPS errors #91
Merged
Log OMPS errors #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csomh
reviewed
Sep 10, 2019
Instead of just returning OMPS errors to client, we should also log what happened in case that client just dropped content of message. Signed-off-by: Martin Bašti <mbasti@redhat.com>
MartinBasti
force-pushed
the
error-reporting
branch
from
e94a68a
to
d6db2e4
Compare
csomh
approved these changes
Sep 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just passing OMPS errors to client, we should also log what
happened in case that client just dropped content of message.
Signed-off-by: Martin Bašti mbasti@redhat.com