integration.Dockerfile: image for integration tests #93
Conversation
| @@ -0,0 +1,35 @@ | |||
| FROM fedora:29 | |||
There was a problem hiding this comment.
Why not fedora:latest? 😄
Based on my experience, it's OK to assume the risk of using :latest, as it is smaller than the risk of forgetting to upgrade to the newest release. And Fedora has a quite fast release cycle, which would mean a new change every 6 month.
There was a problem hiding this comment.
See comments inline. Furthermore:
- I would find it more logical to create this as
tests/integration/Dockerfile tests/integration/README.mdshould be updated to explain the usage of this file.- Who/what is going to be responsible to rebuild this and push it (where?) - would be nice to update the commit message with this information and maybe also mention it in the integration test README.
- Please update the commit message with a general explanation why this change is made - this repo is configured to rebase and merge PRs, so there are not merge commits created. This means everything should be in the commit messages, as PR descriptions won't make it to the history.
| @@ -0,0 +1,35 @@ | |||
| FROM fedora:29 | |||
There was a problem hiding this comment.
Why not fedora:latest? 😄
Based on my experience, it's OK to assume the risk of using :latest, as it is smaller than the risk of forgetting to upgrade to the newest release. And Fedora has a quite fast release cycle, which would mean a new change every 6 month.
| license="GPLv3" | ||
|
|
||
| # Test and build dependencies. | ||
| RUN dnf -y install \ |
There was a problem hiding this comment.
| RUN dnf -y install \ | |
| RUN dnf -y install --setopt=tsflags=nodocs --setopt=install_weak_deps=false \ |
The above would make the resulting image smaller, by not installing documentation and weak dependencies.
| && dnf -y clean all \ | ||
| && rm -rf /tmp/* | ||
|
|
||
| RUN pip3 install tox coveralls |
There was a problem hiding this comment.
Both of these are available from the Fedora repos. Wouldn't it be better to install them from there?
|
|
||
| WORKDIR /src | ||
| COPY . . | ||
| RUN pip3 install -e . |
There was a problem hiding this comment.
Do you expect this to install only OMPS? I.e: all other dependencies should be satisfied by previous dnf installs?
If yes, then using --no-deps could make sure, that there are no additional dependencies pulled in from PyPI.
|
@csomh is there no CI process that automates image builds? I figured this image would be lumped in with those. Side note: I figured out an easier way to create an OMPS image without requiring one be built by this repo. If you would still like this Dockerfile merged, I will address your comments. Otherwise I will close this PR. |
|
@estroz re: side note: I'll close this PR then :) Thanks! |
Image containing all runtime and integration test dependencies. This should be built on each commit to master and pushed remotely, and ideally on every release. The idea is to use this as a base image for operator-courier's as well as OMPS' integration tests.
/cc @csomh @MartinBasti @shawn-hurley @gallettilance