Skip to content

Commit

Permalink
Rename resource names
Browse files Browse the repository at this point in the history
To be consistent with other end-points, rename below three ones:
* content-delivery-content-category -> content-delivery-content-categories
* content-delivery-content-format -> content-delivery-content-formats
* content-delivery-service -> content-delivery-services
The old names remain available for backwards compatibility, but has been
marked deprecated.

JIRA: PDC-1027
  • Loading branch information
erichuanggit committed Oct 28, 2015
1 parent 4a7399e commit 6334361
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
15 changes: 15 additions & 0 deletions pdc/apps/repository/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,11 @@ class ContentCategoryViewSet(StrictQueryParamMixin,
viewsets.GenericViewSet):
"""
API endpoint that allows content_category to be viewed.
Please access this endpoint by [%(HOST_NAME)s/%(API_PATH)s/content-delivery-content-categories/](/%(API_PATH)s/
content-delivery-content-categories/).
Endpoint [%(HOST_NAME)s/%(API_PATH)s/content-delivery-content-category/](/%(API_PATH)s/
content-delivery-content-category/) is deprecated.

This comment has been minimized.

Copy link
@lubomir

lubomir Oct 29, 2015

Member

Could this use $URL:contentdeliverycontentcategory-list instead? With changed base names in the router, both the urls could be autogenerated. Maybe this could even use the $LINK$ macro to simplify it even more.

"""
serializer_class = serializers.ContentCategorySerializer
queryset = models.ContentCategory.objects.all()
Expand All @@ -329,6 +334,11 @@ class ContentFormatViewSet(StrictQueryParamMixin,
viewsets.GenericViewSet):
"""
API endpoint that allows content_format to be viewed.
Please access this endpoint by
[%(HOST_NAME)s/%(API_PATH)s/content-delivery-content-formats/](/%(API_PATH)s/content-delivery-content-formats/).
Endpoint [%(HOST_NAME)s/%(API_PATH)s/content-delivery-content-format/](/%(API_PATH)s/
content-delivery-content-format/) is deprecated.
"""
serializer_class = serializers.ContentFormatSerializer
queryset = models.ContentFormat.objects.all()
Expand All @@ -351,6 +361,11 @@ class ServiceViewSet(StrictQueryParamMixin,
viewsets.GenericViewSet):
"""
API endpoint that allows service to be viewed.
Please access this endpoint by
[%(HOST_NAME)s/%(API_PATH)s/content-delivery-services/](/%(API_PATH)s/content-delivery-services/).
Endpoint [%(HOST_NAME)s/%(API_PATH)s/content-delivery-service/](/%(API_PATH)s/content-delivery-service/) is
deprecated.
"""
serializer_class = serializers.ServiceSerializer
queryset = models.Service.objects.all()
Expand Down
8 changes: 8 additions & 0 deletions pdc/routers.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,21 @@
release_views.ReleaseVariantViewSet)
router.register(r'variant-types', release_views.VariantTypeViewSet,
base_name='varianttype')

router.register(r'content-delivery-content-category', repo_views.ContentCategoryViewSet,
base_name='contentdeliverycontentcategory')
router.register(r'content-delivery-content-format', repo_views.ContentFormatViewSet,
base_name='contentdeliverycontentformat')
router.register(r'content-delivery-service', repo_views.ServiceViewSet,
base_name='contentdeliveryservice')

router.register(r'content-delivery-content-categories', repo_views.ContentCategoryViewSet,
base_name='contentdeliverycontentcategory')
router.register(r'content-delivery-content-formats', repo_views.ContentFormatViewSet,
base_name='contentdeliverycontentformat')
router.register(r'content-delivery-services', repo_views.ServiceViewSet,
base_name='contentdeliveryservice')

router.register(r'osbs', osbs_views.OSBSViewSet,
base_name='osbs')

Expand Down

0 comments on commit 6334361

Please sign in to comment.