Report error on creating release component for missing release #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, seeing that travis approves of the test. |
|
Simple and clear. +1 |
|
Looks good to me. |
The ReleaseField is refactored to be based on SlugRelatedField which provides error handling consistent with rest of the API. There is now a test for creating a release component on a non-existing release. JIRA: PDC-868
lubomir
force-pushed
the
pdc-868-component-for-missing-release
branch
from
1bbf604
to
08dbe39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReleaseField is refactored to be based on SlugRelatedField which
provides error handling consistent with rest of the API.
There is now a test for creating a release component on a non-existing
release.
JIRA: PDC-868