Keep image types synced with formats #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we get this merged soon and into fedora? We had to revert a change that gave us VMDK disk images in the output. This PR was pointed to as being needed for that. context: https://pagure.io/pungi-fedora/pull-request/700 and https://pagure.io/pungi-fedora/pull-request/683 |
The format is basically the file extension, and for each image type there should be only one format. The exception here might be docker, as there might be both tar.xz and tar.gz.
lubomir
force-pushed
the
type-format-mapping
branch
from
7ebc465
to
1a98f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format is basically the file extension, and for each image type there should be only one format. The exception here might be docker, as there might be both tar.xz and tar.gz.