Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release short name validated failed #154

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

t-feng
Copy link
Contributor

@t-feng t-feng commented Mar 26, 2021

Hello:
I was making Linux distributions based on Fedora(lorax for build, anaconda for installer). But it is failed during anaconda install.
After simply debuging for that, I found it is failed in parsering .treeinfo which is a hidden file in ISO.
Because, release-short-name in my treeinfo is not startwith Fedora, CentOS or RHEL.
So, Type-Check failed...
def _validate_short(self): self._assert_type("short", list(six.string_types))
If deserialize_0_0 return "" other then None, It would be better ;)

@lubomir
Copy link
Contributor

lubomir commented Mar 29, 2021

Out of curiosity: what is the name of your distribution?

@lubomir
Copy link
Contributor

lubomir commented Mar 29, 2021

As far as I can tell, nothing directly in productmd should break by having an empty string used as short name.
I'd say it's a reasonably safe change - anything that worked until now will continue to do so without changes. Files that were running into this issue will either start working, or maybe the calling code will fail due to not expecting an empty string. That seems to be fine to me.

Thank you for the patch!

@lubomir lubomir merged commit a518b02 into release-engineering:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants