Make binary image argument optional [CLODDST-2762] #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary image is no longer a mandatory argument. If not specified, then the iiblib operation is called without it. Tests were updated to recognize it being a keyword parameter. Also, 'pyrsistent' dependency's version had to be limited to 0.16.0, as newer versions are not Python 2 compatible.
querti
requested review from
midnightercz,
yashvardhannanavati,
chandwanitulsi and
lipoja
lipoja
approved these changes
Sep 25, 2020
| @@ -1,5 +1,6 @@ | |||
| six | |||
| setuptools | |||
| pyrsistent<=0.16.0; python_version == '2.7' | |||
There was a problem hiding this comment.
It looks like this one is not used. Is it a dependency of something?
There was a problem hiding this comment.
It's a pushcollector dependency. It seems that new version was released which is not Python 2 compatible, which causes the Python 2 tests initialization to fail. This line constraints the version for Python 2 tests.
midnightercz
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary image is no longer a mandatory argument. If not specified, then the iiblib operation is called without it. Tests were updated to recognize it being a keyword parameter.