Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports from iiblib [CLOUDDST-3064] #15

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix imports from iiblib [CLOUDDST-3064] #15

merged 1 commit into from
Oct 19, 2020

Conversation

pbortlov
Copy link
Contributor

@pbortlov pbortlov commented Oct 9, 2020

  • fix iiblib imports
  • remove unused imports

@pbortlov pbortlov marked this pull request as ready for review October 13, 2020 07:32
@midnightercz
Copy link
Member

Looks good but needs to be rebased on release-engineering/iiblib#25

@pbortlov
Copy link
Contributor Author

Looks good but needs to be rebased on release-engineering/iiblib#25

Yeah, we will wait when is the iiblib merged and then we will rebase.

@lipoja
Copy link
Contributor

lipoja commented Oct 13, 2020

LGTM - once the required PR is merged I will approve it.

@pbortlov pbortlov changed the title Fix imports from iiblib Fix imports from iiblib [CLOUDDST-3064] Oct 14, 2020
@lipoja lipoja merged commit 79f9ddc into release-engineering:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipoja lipoja lipoja approved these changes

@midnightercz midnightercz midnightercz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbortlov @midnightercz @lipoja