Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation_list and index_image_resolved attributes [CLOUDDST-3836] #20

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Add deprecation_list and index_image_resolved attributes [CLOUDDST-3836] #20

merged 2 commits into from
Mar 29, 2021

Conversation

pbortlov
Copy link
Contributor

@pbortlov pbortlov commented Mar 15, 2021 •
edited

  • add deprecation_list and index_image_resolved attributes due to iiblib-3.0.0 changes

https://projects.engineering.redhat.com/browse/CLOUDDST-3836

pbortlov
pbortlov commented Mar 15, 2021
View reviewed changes
setup.py Show resolved Hide resolved
@pbortlov pbortlov marked this pull request as ready for review March 15, 2021 15:58
@pbortlov
Copy link
Contributor Author

@midnightercz @lipoja @querti PTAL

yashvardhannanavati
yashvardhannanavati requested changes Mar 18, 2021
View reviewed changes
README.rst Outdated Show resolved Hide resolved
tests/test_iib_ops.py Outdated Show resolved Hide resolved
@pbortlov pbortlov changed the title Add deprecation list attribute Add deprecation list attribute [CLOUDDST-3836] Mar 22, 2021
@pbortlov pbortlov force-pushed the deprecate-bundle branch 2 times, most recently from 28199ca to 68f6fe0 Compare March 22, 2021 14:28
yashvardhannanavati
yashvardhannanavati reviewed Mar 22, 2021
View reviewed changes
tests/utils.py Outdated Show resolved Hide resolved
@pbortlov pbortlov force-pushed the deprecate-bundle branch 2 times, most recently from cc51736 to 7d3d784 Compare March 23, 2021 14:04
@yashvardhannanavati
Copy link
Contributor

@pbortlov The CI seems to be failing. Could you please fix that before merging this?

@pbortlov pbortlov force-pushed the deprecate-bundle branch 2 times, most recently from 9567534 to a7fcbe2 Compare March 23, 2021 15:42
@pbortlov
Copy link
Contributor Author

@pbortlov The CI seems to be failing. Could you please fix that before merging this?

#21 @yashvardhannanavati

@pbortlov pbortlov changed the title Add deprecation list attribute [CLOUDDST-3836] Add deprecation_list and index_image_resolved attributes [CLOUDDST-3836] Mar 24, 2021
@pbortlov
Copy link
Contributor Author

@midnightercz @querti @yashvardhannanavati @chandwanitulsi @lipoja I add another commit to fix index_image_resolved.

lipoja
lipoja reviewed Mar 24, 2021
View reviewed changes
tests/utils.py Show resolved Hide resolved
lipoja
lipoja reviewed Mar 24, 2021
View reviewed changes
tests/utils.py Outdated Show resolved Hide resolved
@yashvardhannanavati yashvardhannanavati merged commit 4485cfe into release-engineering:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipoja lipoja lipoja left review comments

@yashvardhannanavati yashvardhannanavati yashvardhannanavati approved these changes

@midnightercz midnightercz midnightercz approved these changes

@chandwanitulsi chandwanitulsi Awaiting requested review from chandwanitulsi

@querti querti Awaiting requested review from querti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pbortlov @yashvardhannanavati @lipoja @midnightercz @chandwanitulsi @querti