Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to push to quay #27

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Remove ability to push to quay #27

merged 2 commits into from
Apr 1, 2021

Conversation

querti
Copy link
Contributor

@querti querti commented Apr 1, 2021

Since pub is not yet ready to support this functionality, the commit that adds this functionality will be added at a later date.

Since pub is not yet ready to support this functionality, the commit
that adds this functionality will be added at a later date.
@querti querti marked this pull request as ready for review April 1, 2021 07:55
@lipoja
Copy link
Contributor

lipoja commented Apr 1, 2021

I guess when we merge this we will introduce (revert) some issues that we should fix before release.
For example changes in DEPENDENCY_LINKS in setup.py, MANIFEST.in and some more.

@querti
Copy link
Contributor Author

querti commented Apr 1, 2021

@lipoja This is not an automatic revert, I purposely included these changes so that the release would be possible. Some of the settings are strange (like in setup.py) but they worked in the past, so let's revert to them

@lipoja
Copy link
Contributor

lipoja commented Apr 1, 2021

@querti OK, I thought that just revert of your previous commit.
However I think at least dependency_links should point to correct repo.

@querti
Copy link
Contributor Author

querti commented Apr 1, 2021

@querti OK, I thought that just revert of your previous commit.
However I think at least dependency_links should point to correct repo.

Already fixed

@lipoja
Copy link
Contributor

lipoja commented Apr 1, 2021

@querti OK, I thought that just revert of your previous commit.
However I think at least dependency_links should point to correct repo.

Already fixed

wow, you are faster then light. ⚡

@querti querti merged commit 926975d into release-engineering:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants