Merge pull request #35 from rohanpm/name-executors

refactor: give executor a meaningful name
release-engineering · Jul 28, 2021 · 39d8b5c · 39d8b5c
2 parents 33c37ed + 0c94dfe
commit 39d8b5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- n/a
+### Changed
+
+- Internally created executors are now named for improved metrics and debuggability.
 
 ## [1.1.0] - 2021-03-22
 

diff --git a/pubtools/_pulp/ud.py b/pubtools/_pulp/ud.py
@@ -38,7 +38,7 @@ def __init__(self, url, max_retry_sleep=None, **kwargs):
 
         self._session_attrs = kwargs
         self._executor = (
-            Executors.thread_pool(max_workers=self._REQUEST_THREADS)
+            Executors.thread_pool(name="ud-client", max_workers=self._REQUEST_THREADS)
             .with_map(self._check_http_response)
             .with_retry(**retry_args)
         )

diff --git a/requirements.txt b/requirements.txt
@@ -1,6 +1,6 @@
 six
 pubtools-pulplib>=2.8.0
 fastpurge
-more_executors>=2.2.0
+more_executors>=2.7.0
 pushcollector>=1.2.0
 pushsource