Added GitHub Actions Workflow #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
requested changes
Aug 24, 2021
.github/workflows/tox-test.yml
Outdated
| - name: Install Tox | ||
| run: pip install tox | ||
| - name: Install pytest cov | ||
| run: pip install pytest-cov |
There was a problem hiding this comment.
I see, this makes sense, but may I suggest the following then:
- this shouldn't be pytest-cov specifically because codecov-action doesn't depend on "pytest-cov", it only depends on "coverage" (i.e. not the pytest stuff) - right?
- could we please move this to after we run "tox -e cov", i.e. just before we run codecov-action? I think that makes the intent clearer, that we're installing this just for that action. A brief comment mentioning that would also be nice.
|
@daminijain23, I submitted most of the changes here, with commits squashed. Let's use a new PR if there are further changes needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .github/workflows/tox-test.yml and .github/workflows/release.yml.
Removed .travis.yml
GitHub Actions and Travis workflows can run parallel. In such case, if both run successfully only then GitHub reports a success.
On reducing the number of tests, coverage also reduced.