Packaging improvements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rohanpm
commented
Feb 18, 2019
•
rohanpm
commented
- Ensure supporting files are included in distribution (most critically, LICENSE)
- Clean up unnecessary code
- Make setup.py read from requirements.txt
- Clarify license
rohanpm
force-pushed
the
packaging-fixes
branch
from
a2af874
to
65fb462
Compare
mztahir
approved these changes
Feb 18, 2019
danrodrig
approved these changes
Feb 18, 2019
rohanpm
force-pushed
the
packaging-fixes
branch
from
65fb462
to
323327f
Compare
These supporting files should be included in the source distribution shipped to PyPI. Most critically, the LICENSE ought to be shipped with the source. Also removes the code in setup.py tolerating absence of README.md. The reason it was missing for older python/setuptools was that README.md isn't implicitly included in the source dist for those old versions.
Avoids maintaining the same list in two places.
Simply writing "GPLv3" makes it ambiguous whether it's intended to include the "or any later version" clause (although this was included in the setup.py metadata). Copy the recommended blurb from the license to make it explicit that "any later version" does apply here.
rohanpm
force-pushed
the
packaging-fixes
branch
from
323327f
to
2c4e3c2
Compare
|
There's a problem with coveralls all of a sudden, affecting all pull requests. Please ignore it here. I've filed separate issue #12 for that. |
alexandrevicenzi
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.