Handle more fedora-messaging exceptions when publishing messages #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as PublishReturned and ConnectionException, messaging can raise PublishTimeout (publishing timed out) or PublishForbidden (publishing was denied for lack of permission) when you attempt to publish a message. We should handle these as well. At present it seems like if this happens, the exception being unhandled ultimately causes WSGI to return a 500 or 504 error to the client that submitted the result; the client may then try and submit the result again, leading to it being duplicated many times. If we handle the exception instead, the client should get a successful response and not re-submit the result. The message not being published is still a problem, but probably not as bad as clients constantly re-submitted results forever. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Original from https://pagure.io/taskotron/resultsdb/pull-request/157 - I will merge after the tests succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as PublishReturned and ConnectionException, messaging
can raise PublishTimeout (publishing timed out) or
PublishForbidden (publishing was denied for lack of permission)
when you attempt to publish a message. We should handle these
as well. At present it seems like if this happens, the exception
being unhandled ultimately causes WSGI to return a 500 or 504
error to the client that submitted the result; the client may
then try and submit the result again, leading to it being
duplicated many times. If we handle the exception instead, the
client should get a successful response and not re-submit the
result. The message not being published is still a problem, but
probably not as bad as clients constantly re-submitted results
forever.
Signed-off-by: Adam Williamson awilliam@redhat.com