You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#49 asks for adding a 'version' attribute to UbiConfig class, and when config is loaded by GitlabLoader, this field should be populated with partial branch name.
However, for LocalLoader, there's no way to get the version and populate it while loading, which makes LocalLoader not useable (if the version field is None, then the whole UbiConfig object is useless)
In order to make LocalLoader useable again, I propose two solutions:
Rewrite LocalLoader to make it git aware:
Now the local repo isn't simply directories and files, but a local git repo has the same layout/branches of the remote gitlab repo, so LocalLoader can get the branch information just as GitlabLoader does.
Restrict the local directories layout. Config files of a specific version should be put under one directory and the directory should be named after version. For example:
configs/
├── ubi7.1
│ └── rhel-atomic-host.yaml
└── ubi7.2
└── rhel-7-for-power-le.yaml
Issue Type
Feature Request
Current behavior
LocalLoader couldn't find version info.
Desired behavior
LocalLoader should be version aware and populate the UbiConfig.version field while loading
Use case
Load configs from local.
Additional Information
The text was updated successfully, but these errors were encountered:
Summary
#49 asks for adding a 'version' attribute to UbiConfig class, and when config is loaded by GitlabLoader, this field should be populated with partial branch name.
However, for LocalLoader, there's no way to get the version and populate it while loading, which makes LocalLoader not useable (if the version field is None, then the whole UbiConfig object is useless)
In order to make LocalLoader useable again, I propose two solutions:
Rewrite LocalLoader to make it git aware:
Now the local repo isn't simply directories and files, but a local git repo has the same layout/branches of the remote gitlab repo, so LocalLoader can get the branch information just as GitlabLoader does.
Restrict the local directories layout. Config files of a specific version should be put under one directory and the directory should be named after version. For example:
configs/
├── ubi7.1
│ └── rhel-atomic-host.yaml
└── ubi7.2
└── rhel-7-for-power-le.yaml
Issue Type
Current behavior
LocalLoader couldn't find version info.
Desired behavior
LocalLoader should be version aware and populate the UbiConfig.version field while loading
Use case
Load configs from local.
Additional Information
The text was updated successfully, but these errors were encountered: