Remove call to logging.basicConfig() #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging.basicConfig() is something which can only be done once
per process.
Simply importing a library shouldn't have the side-effect of
calling this. It means for example that a command-line tool's
call to logging.basicConfig with some arguments will be ignored;
and if multiple libraries do this with different arguments, it
means log behavior mysteriously changes depending on the order
in which modules are imported.