Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct version of ubi config file for ubi repository population #138

Open
rbikar opened this issue Oct 3, 2019 · 0 comments
Open

Comments

@rbikar
Copy link
Member

rbikar commented Oct 3, 2019

Summary

In order to support new branching scheme for ubi config repos, we need to reflect that also in ubipop. In short, ubipop should select correct ubi config file based on version for given repo.
There are two scenarios for different types of repos:
For DOT repositories:

  • select ubi config by platform_full_version repo note

For mainline (e.g. 7Server) repositories

  • select ubi config by ubi_config_version note
  • if repo note is not available, use default version ("7" for ubi7, "8" for ubi8 )

I both scenarios, if a config is not available for given version, fallback to default version.
Version of ubi config will available via version attr - release-engineering/ubi-config#49

Issue Type

  • Feature Request

Current behavior

Currently we don't support selecting ubi config file per version.

Desired behavior

  • for every ubi repository correct ubi config is select by its version
  • for determining which version should be used take platform_full_version repo note for DOT repositories and ubi_config_version repo note for mainline repositories
  • if ubi config is not available for given version, fallback to default version ("7" for ubi7, "8" for ubi8 )

Use case

Ubi DOT repositories are considered as testing repos, so we may want to used different (new) config file for for DOT repositories than for mainline repositories which are customer facing.

JayZ12138 added a commit to JayZ12138/ubi-population-tool that referenced this issue Oct 15, 2019
This resloves release-engineering#138
A new attr is added to Repo class and it will be populated while
searching repos.

After all config files are loaded, it now creates a config map, which
helps find the right config file for the repo to populate.
JayZ12138 added a commit to JayZ12138/ubi-population-tool that referenced this issue Oct 23, 2019
This resloves release-engineering#138
A new attr is added to Repo class and it will be populated while
searching repos.

After all config files are loaded, it now creates a config map, which
helps find the right config file for the repo to populate.
JayZ12138 added a commit that referenced this issue Oct 24, 2019
* Use correct version of ubi config file for population

This resloves #138
A new attr is added to Repo class and it will be populated while
searching repos.

After all config files are loaded, it now creates a config map, which
helps find the right config file for the repo to populate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant