Replace cmp_version with rpm python bindings #110
Conversation
This change replaces buggy cmp_version package with python bindings of official rpm project.
rbikar
changed the title
|
|
||
| try: | ||
| from urllib.parse import urljoin | ||
| except ImportError: | ||
| from urlparse import urljoin | ||
|
|
||
| import requests | ||
| from rpm import labelCompare as label_compare # pylint: disable=no-name-in-module |
There was a problem hiding this comment.
Instead of adding an extra dep, would not be easy to just borrow this function?
There was a problem hiding this comment.
yeah, sounds like a plan.
There was a problem hiding this comment.
But it's implemented in C, isn't it? I would rather keep our stuff pure-python as much as we can.
There was a problem hiding this comment.
Yep, it's in C, I also wouldn't like to have extra C code in our stuff.
There was a problem hiding this comment.
Oh, if it's in C makes sense.
| @@ -1,4 +1,4 @@ | |||
| requests | |||
| more-executors | |||
| ubi-config | |||
| cmp_version | |||
| rpm-py-installer | |||
There was a problem hiding this comment.
I think this might cause some issues for the RPM packages of this project. Is this going to result in the egg always requiring some "rpm-py-installer" distribution to be present, while it's actually nonsense to set that as Requires in an RPM?
In general though I think it's OK for what we put in these repos to be somewhat ignorant of RPM packaging complexities. So this comment is more like a heads up that this might cause us to run into issues and we may need patches in dist-git, or may need to revisit this later.
This change replaces buggy cmp_version package
with python bindings of official rpm project.
This should ensure that ubipop will sort rpms by correctly implemented and maitained vercmp algorithm.
Fixes #104