Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Actions #156

Merged
merged 10 commits into from
Sep 7, 2021
Merged

Conversation

daminijain23
Copy link
Contributor

Added - release.yml and tox-test.yml
Removed - .travis.yml

https://projects.engineering.redhat.com/browse/RHELDST-7276

@cd-red-bot
Copy link

Can one of the admins verify this patch?

@rbikar
Copy link
Member

rbikar commented Aug 9, 2021

@daminijain23
Looks good to me, but can you please check whether it's possible also to trigger JenkinsCI by GH Actions? Currently it's done by manually adding comment to PR like "run tests" or similar.

- name: Install RPM
run: |
sudo apt-get install -y rpm
sudo apt-get install -y libkrb5-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is installation of libkrb5-dev required?

@rbikar
Copy link
Member

rbikar commented Sep 3, 2021

@daminijain23
I added one comment about installation of some specific package, can you have a look? Otherwise this looks OK, and I would rather merge it, so we can test it properly and later add support for JENKINS CI trigger, if possible.
Also in one newer PR #162, it looks that Travis is not part of checks for some reason :(

@rbikar
Copy link
Member

rbikar commented Sep 6, 2021

@daminijain23
I just wonder, why travis.yml is back. This file shouldn't be needed now. Or am I missing something?

@daminijain23
Copy link
Contributor Author

@rbikar
krb5 package have been removed from coverage flow as it wasn't required.
.travis.yml was added back as backup in case github actions errors out and until all issues get resolved

@rbikar
Copy link
Member

rbikar commented Sep 7, 2021

O

@rbikar
krb5 package have been removed from coverage flow as it wasn't required.
.travis.yml was added back as backup in case github actions errors out and until all issues get resolved

OK, sounds good, I'll merge this now and let's see how it works :)

@rbikar rbikar merged commit b219b0a into release-engineering:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants