RPMs matching re-implemented [RHELDST-6392] #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbikar
force-pushed
the
match-rpms-effectively
branch
2 times, most recently
from
b0a9f9e
to
6cdfc1d
Compare
This rather bigger change moves matching non-modular binary, debug and source packages to separate class. This change provides 1:1 functionality as previous code, but is more robust, reliable and uses better paralellizition and should be also a bit faster than the previous implementation. I also removed some unused code, added and improved tests, added some custom config to pylint in order to pass static checks.
rbikar
force-pushed
the
match-rpms-effectively
branch
from
6cdfc1d
to
7ad1cc6
Compare
|
run tests |
|
Failure in integration tests is a known issue: RHELDST-7382. It's missing line in logs, I asked for disabling the check. |
negillett
approved these changes
Aug 25, 2021
rohanpm
approved these changes
Aug 26, 2021
|
|
||
| BATCH_SIZE = int(os.getenv("UBIPOP_BATCH_SIZE", "250")) | ||
| # need to set significantly lower batches for general rpm search | ||
| # otherwise db may very likely hit OOM error. | ||
| BATCH_SIZE_RPM = int(os.getenv("UBIPOP_BATCH_SIZE_RPM", "15")) |
There was a problem hiding this comment.
This value is surprisingly low. If it really has to be this low to succeed, I wonder if there's something else going on here like queries being unexpectedly inefficient.
There was a problem hiding this comment.
Well, first I tested it with the batch size 250 and queries for RPMs immediately caused OOM on DB and outage on stage rhsm-pulp. Value 25 worked OK, 50 caused OOM as well. So I rather went to safer value 15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather bigger change moves matching non-modular binary,
debug and source packages to separate class.
This change provides 1:1 functionality as previous code, but is more
robust, reliable and uses better paralellizition and should be also
a bit faster than the previous implementation.
I also removed some unused code, added and improved tests, added
some custom config to pylint in order to pass static checks.