Unify access to ubiconfig in Matcher subclasses #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously methods of ModularMatcher class accessed ubiconfig via ubiconfig.modules, but RpmMatcher used ubiconfig directly. So let's unify the access and use ubiconfig directly also in ModularMatcher.
rbikar
force-pushed
the
standardize-access-to-ubiconfig
branch
from
a92ddd0
to
0c7ca2a
Compare
|
This will be soon deprecated, dropping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously methods of ModularMatcher class accessed ubiconfig via
ubiconfig.modules, but RpmMatcher used ubiconfig directly.
So let's unify the access and use ubiconfig directly also
in ModularMatcher.