Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching ubi-config by major version or content set regex [RHELDST-6396] #166

Merged

Conversation

rbikar
Copy link
Member

@rbikar rbikar commented Sep 8, 2021

Added support for matching correct ubi-config item by
major version and/or by content set regex.
Features are enabled also for CLI.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #166 (d72387b) into master (38179bc) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   92.39%   92.51%   +0.11%     
==========================================
  Files           5        5              
  Lines         881      895      +14     
==========================================
+ Hits          814      828      +14     
  Misses         67       67              
Impacted Files Coverage Δ
ubipop/__init__.py 85.75% <100.00%> (+0.54%) ⬆️
ubipop/cli.py 95.65% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38179bc...d72387b. Read the comment docs.

@rbikar
Copy link
Member Author

rbikar commented Sep 8, 2021

run tests

@rbikar rbikar marked this pull request as ready for review September 8, 2021 12:01
negillett
negillett previously approved these changes Sep 8, 2021
Added support for matching correct ubi-config item by
major version and/or by content set regex.
Features are enabled also for CLI.
@rbikar
Copy link
Member Author

rbikar commented Sep 8, 2021

Rebased on the latest master - new coverage tool doesn't seem to work, if the feature branch is behind master.

@rbikar
Copy link
Member Author

rbikar commented Sep 8, 2021

run tests

@rbikar rbikar merged commit 7878eda into release-engineering:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants