Call logging.basicConfig only within main #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merely importing a module shouldn't have the side-effect of changing the global logging config, which can only be done once per process. It's fragile and could lead to confusing behavior where log format differs depending on the order of imports. Since this is only intended to enable output for the CLI, let's move it within the CLI's main method.
alexandrevicenzi
approved these changes
Mar 21, 2019
rbikar
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merely importing a module shouldn't have the side-effect of changing
the global logging config, which can only be done once per process.
It's fragile and could lead to confusing behavior where log format
differs depending on the order of imports.
Since this is only intended to enable output for the CLI, let's
move it within the CLI's main method.