Fix linter issues #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandrevicenzi
commented
May 3, 2019
alexandrevicenzi
commented
- Fixed code styling
- Fixed most pylint issues
alexandrevicenzi
requested review from
midnightercz,
JayZ12138,
danrodrig and
litleleprikon
danrodrig
reviewed
May 7, 2019
ubipop/__init__.py
Outdated
| @@ -163,7 +169,7 @@ def _get_repo_counterpart(self, input_repo, repos_to_match): | |||
| if input_repo.arch == repo.arch and \ | |||
| input_repo.platform_full_version == repo.platform_full_version: | |||
| return repo | |||
|
|
|||
| return None | |||
There was a problem hiding this comment.
Notice that we are no longer enforcing inconsistent-return-statements
There was a problem hiding this comment.
This also a reason for failing test coverage check.
danrodrig
previously approved these changes
May 7, 2019
rohanpm
previously approved these changes
May 8, 2019
rbikar
previously approved these changes
May 9, 2019
- Fixed code styling - Fixed most pylint issues
alexandrevicenzi
dismissed stale reviews from rbikar, rohanpm, and danrodrig
via
092b8ed
rbikar
approved these changes
May 10, 2019
|
@rbikar I try to squash to not pollute the history, but good point about review. |
I always squash before merging to master (there is an option for it: squash and merge). So history is not polluted. |
danrodrig
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.